Skip to content

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 24, 2023

This PR changes the "current" version of the documentation to 8.9 and changes that set of docs from "unreleased" to "released".

Do not merge until release day

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl
Copy link
Contributor Author

lcawl commented Jul 24, 2023

@elasticmachine run elasticsearch-ci/docs rebuild

@lcawl
Copy link
Contributor Author

lcawl commented Jul 24, 2023

APM doc link issues being fixed in elastic/apm-server#11279, elastic/apm-server#11278

@bmorelli25
Copy link
Member

APM redirects merged. Rerunning.

@bmorelli25
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

1 similar comment
@lcawl
Copy link
Contributor Author

lcawl commented Jul 24, 2023

@elasticmachine run elasticsearch-ci/docs

@lcawl
Copy link
Contributor Author

lcawl commented Jul 24, 2023

I created elastic/elasticsearch#97910 to work around the remaining broken links.

@lcawl
Copy link
Contributor Author

lcawl commented Jul 24, 2023

@elasticmachine run elasticsearch-ci/docs warnlinkcheck

jrodewig pushed a commit to elastic/elasticsearch that referenced this pull request Jul 24, 2023
Relates to elastic/docs#2722, #96415

This PR provides a work-around for the following doc build broken links:

```
13:40:21 INFO:build_docs:Bad cross-document links:
13:40:21 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/elasticsearch/client/javascript-api/8.9/api-reference.html contains broken links to:
13:40:21 INFO:build_docs:   - en/elasticsearch/reference/8.9/security-api-create-cross-cluster-api-key.html
13:40:21 INFO:build_docs:   - en/elasticsearch/reference/8.9/security-api-update-cross-cluster-api-key.html
13:40:21 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/elasticsearch/client/javascript-api/current/api-reference.html contains broken links to:
13:40:21 INFO:build_docs:   - en/elasticsearch/reference/8.9/security-api-create-cross-cluster-api-key.html
13:40:21 INFO:build_docs:   - en/elasticsearch/reference/8.9/security-api-update-cross-cluster-api-key.html
```
@jrodewig
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@lcawl lcawl marked this pull request as ready for review July 24, 2023 23:56
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it when a plan comes together.

@jrodewig jrodewig merged commit ad48e09 into elastic:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants