Build and package Elastic.Apm.SerilogEnricher project #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM but got a bit carried away with a follow up PR to this to get us on AppVeyor to the point where #15 now obsoletes this (e.g Projects.fsx and nuspec files). |
gregkalapos
reviewed
Dec 11, 2019
There was a problem hiding this comment.
This LGTM but got a bit carried away with a follow up PR to this to get us on AppVeyor to the point where #15 now obsoletes this (e.g Projects.fsx and nuspec files).
LGTM too, I'd be also happier with having everything in the csproj file without nuspec as in #15.
https://github.com/elastic/ecs-dotnet/pull/15/files#diff-686883fe563167eecc1599d66feaa5a4R8
|
Closing as superceded by #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the Elastic.Apm.SerilogEnricher project in the build and packaging process.
<summary>node in nuspec file needs writing.