Example to demonstrate registration of the EcsTextFormatter within an AspnetCore application. #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… AspnetCore application. Fixes #62 - Also ensures ay access to the resolved HttpContext are null-checked before access - Also enhances parsing of the UserAgent using a static property, provided by including code from https://github.com/ua-parser/uap-csharp (Apache 2.0)
codebrain
added
bug
russcam
suggested changes
Mar 13, 2020
examples/aspnetcore-with-serilog/Controllers/WeatherForecastController.cs
Show resolved
Hide resolved
…into serilog-registration
Add example to root README
|
Brilliant! This does the trick nicely. Can confirm that this solves #62 for me when running locally. For some reason I didn't know you could get services from ctx.Configuration this way, so that was very useful. Totally agree that an Examples project is super useful here! I have a suggestion for the Elastic.CommonSchema.Client.Ip field to be changed to string[] and then the value be split so we have separate IPv4 and IPv6 values, but I'll submit a separate feature request for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62