fix #68 labels should be dict of string to string

[Mpdreamz]

Fixes #68

[ghost]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Build Cause: Pull request #84 updated

• Start Time: 2021-06-01T00:11:00.459+0000

• Duration: 14 min 24 sec

• Commit: a650f5c

Test stats 🧪

Test	Results
Failed	0
Passed	78
Skipped	0
Total	78

Trends 🧪

[Mpdreamz]

@gregkalapos @russcam @sgryphon this one has to go in 1.6.0 since we a have minor non breaking clause in https://github.com/elastic/ecs-dotnet#versioning

[russcam]

Wondering if labels should be Dictionary<string, string> or whether it should be a Dictionary constrained to scalar values. For example, the APM agent labels can be any of string, number or boolean, and are modelled internally with a Label type:

https://github.com/elastic/apm-agent-dotnet/blob/2c433d31c45444e026081721e9c4190dadc383b8/src/Elastic.Apm/Api/Label.cs

As far as I understand, APM agent labels map to the ECS labels field. Should Elastic Common Schema .NET have a similar type to constrain label values?

[sgryphon]

@russcam this fix needs to be in 1.6 (if it is not there already... although I guess you just filter on tag = 1.6)