Skip to content

Conversation

codebrain
Copy link
Contributor

Fix typo, should read as example

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think you need to run make update to make CI happy.

We should get this fix also into the master branch.

@codebrain
Copy link
Contributor Author

@ruflin - its proving to be a little difficult to run this in Windows :)

@codebrain
Copy link
Contributor Author

Looks like I might be able to workaround this by editing the generated files directly?

@codebrain codebrain changed the title Update process.yml Fix exmple type to example for fields.yml and process.yml May 20, 2019
@ruflin
Copy link
Contributor

ruflin commented May 22, 2019

@codebrain Sorry about that Windows issue.We should probably fix that. If you give me permission on your branch, I can run it for you.

@webmat
Copy link
Contributor

webmat commented May 22, 2019

@codebrain I'd love your help on making this more easy to run on Windows at some point. What are the failures you're seeing?

Oh, is it just because of make? I see Beats partially solves this with mage...

Any suggestions welcome on replacing make :-) Could be mage, could be another task runner in Python.

@webmat
Copy link
Contributor

webmat commented May 22, 2019

I just noticed this is a PR to the 1.0 branch. I'll reapply your contributions on top of master, and then backport to 1.0.

Need to keep the workflow uniform :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants