feat(fips): Disable encrypted private key support when in FIPS mode #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
enhancement
michel-laterman
requested review from
belimawr and
rdner
and removed request for
a team
💚 Build Succeeded
|
cmacknz
approved these changes
Feb 12, 2025
simitt
reviewed
Feb 17, 2025
There was a problem hiding this comment.
Sorry for being late with the review - @michel-laterman can you please create another PR with a test for fips mode, ensuring that errors are returned.
Created #280 for tracking this.
This was referenced Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Disable support for encrypted private keys when built in FIPS mode.
Checklist
I have added tests that prove my fix is effective or that my feature works