Skip to content

Ensure BootstrapElasticsearch is virtual #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Ensure BootstrapElasticsearch is virtual #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Elastic.Ingest.Elasticsearch/ElasticsearchChannelBase.Bootstrap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public abstract partial class ElasticsearchChannelBase<TEvent, TChannelOptions>
protected abstract (string, string) GetDefaultIndexTemplate(string name, string match, string mappingsName, string settingsName);


public async Task<bool> BootstrapElasticsearchAsync(BootstrapMethod bootstrapMethod, string? ilmPolicy = null, CancellationToken ctx = default)
public virtual async Task<bool> BootstrapElasticsearchAsync(BootstrapMethod bootstrapMethod, string? ilmPolicy = null, CancellationToken ctx = default)
{
if (bootstrapMethod == BootstrapMethod.None) return true;

Expand All @@ -44,7 +44,7 @@ public async Task<bool> BootstrapElasticsearchAsync(BootstrapMethod bootstrapMet
return true;
}

public bool BootstrapElasticsearch(BootstrapMethod bootstrapMethod, string? ilmPolicy = null)
public virtual bool BootstrapElasticsearch(BootstrapMethod bootstrapMethod, string? ilmPolicy = null)
{
if (bootstrapMethod == BootstrapMethod.None) return true;

Expand Down