Skip to content

f1106b9b causes build failures due to valid log lines #1296

@efd6

Description

@efd6

Since f1106b9 valid builds can fail with

Error: error running package system tests: could not complete test run: check log messages failed: malformed docker-compose log line

With judicious addition of information to the error message:

diff --git a/internal/stack/parselogs.go b/internal/stack/parselogs.go
index 6b8557e..a2d62b6 100644
--- a/internal/stack/parselogs.go
+++ b/internal/stack/parselogs.go
@@ -41,7 +41,7 @@ func ParseLogs(options ParseLogsOptions, process func(log LogLine) error) error
                messageSlice := strings.SplitN(line, "|", 2)

                if len(messageSlice) != 2 {
-                       return fmt.Errorf("malformed docker-compose log line")
+                       return fmt.Errorf("malformed docker-compose log line: %q", line)
                }

                messageLog := messageSlice[1]

we see

Error: error running package system tests: could not complete test run: check log messages failed: malformed docker-compose log line: "Attaching to elastic-package-stack_elastic-agent_1"

Replacing the error return with a continue allows completion of the assessment of log lines that appears to be the intention of #1256.

/cc @mrodm

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions