Skip to content

Add support for dash in shellinit stack #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Add support for dash in shellinit stack #1012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions internal/stack/shellinit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,19 +64,15 @@ set -x %s %s;
)

// availableShellTypes list all available values for s in initTemplate
var availableShellTypes = []string{"bash", "fish", "sh", "zsh"}
var availableShellTypes = []string{"bash", "dash", "fish", "sh", "zsh"}

// InitTemplate returns code templates for shell initialization
func initTemplate(s string) (string, error) {
switch s {
case "bash":
case "bash", "dash", "sh", "zsh":
return posixTemplate, nil
case "fish":
return fishTemplate, nil
case "sh":
return posixTemplate, nil
case "zsh":
return posixTemplate, nil
default:
return "", errors.New("shell type is unknown, should be one of " + strings.Join(availableShellTypes, ", "))
}
Expand Down