Skip to content

Conversation

@mrodm
Copy link
Contributor

@mrodm mrodm commented Oct 25, 2022

This PR updates the Dockerfile that creates the Elastic Package Registry image to configure the Elastic Package Registry production DNS (https://epr.elastic.co) to be used as proxy. Currently, the default value used is the snapshot one (https://epr-snapshot.elastic.co)

@mrodm mrodm requested a review from a team October 25, 2022 08:39
@mrodm mrodm self-assigned this Oct 25, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-25T08:39:39.757+0000

  • Duration: 33 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 854
Skipped 0
Total 854

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Collaborator

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (35/35) 💚
Files 66.667% (86/129) 👍
Classes 61.413% (113/184) 👍
Methods 47.52% (364/766) 👍
Lines 30.723% (3288/10702) 👍
Conditionals 100.0% (0/0) 💚

ENV EPR_DISABLE_PACKAGE_VALIDATION=true

ENV EPR_FEATURE_PROXY_MODE=true
ENV EPR_PROXY_TO=https://epr.elastic.co
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed if we are going to change the default in package-registry itself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just add it in case we want to push this change quick into elastic-package.

This is not totally mandatory, if we can wait until the package-registry release and the required update here in elastic-package (update the docker image used for package-registry - https://github.com/elastic/elastic-package/blob/main/internal/profile/static.go#L126).

I'll keep the PR opened in case we see it is worthy.

@mrodm mrodm marked this pull request as ready for review November 14, 2022 09:36
@mrodm mrodm merged commit a7a64a2 into elastic:main Nov 14, 2022
@mrodm mrodm deleted the update_proxy_url branch November 14, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants