Remove code related to Package Storage v1 and update README #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readme updated without the promote and publish commands. Removed also the reference to Github Authorization tokens since there is no need to communicate from elastic-package to Github to create Pull Requests.
mrodm
commented
Oct 27, 2022
| changelogTable = append(changelogTable, formatChangelogEntry(change)) | ||
| } | ||
| table := tablewriter.NewWriter(os.Stdout) | ||
| table := tablewriter.NewWriter(w) |
There was a problem hiding this comment.
Update to use the same writer as the other table, so it can be tested in cmd/status_test.go
mrodm
commented
Oct 27, 2022
Comment on lines
-287
to
-316
| ### GitHub authorization | ||
|
|
||
| The `promote` and `publish` commands require access to the GitHub API to open pull requests or check authorized account data. | ||
| The tool uses the GitHub token to authorize user's call to API. The token can be stored in the `~/.elastic/github.token` | ||
| file or passed via the `GITHUB_TOKEN` environment variable. | ||
|
|
||
| Here are the instructions on how to create your own personal access token (PAT): | ||
| https://docs.github.com/en/github/authenticating-to-github/creating-a-personal-access-token | ||
|
|
||
| Make sure you have enabled the following scopes: | ||
| * `public_repo` — to open pull requests on GitHub repositories. | ||
| * `read:user` and `user:email` — to read your user profile information from GitHub in order to populate pull requests appropriately. | ||
|
|
||
| After creating or modifying your personal access token, authorize the token for | ||
| use of the Elastic organization: https://docs.github.com/en/github/authenticating-to-github/authenticating-with-saml-single-sign-on/authorizing-a-personal-access-token-for-use-with-saml-single-sign-on | ||
|
|
There was a problem hiding this comment.
As elastic-package should not create any PRs, I think this section is not needed anymore. Is there any other usage for this token ? @elastic/ecosystem
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
mrodm
changed the title
jsoriano
approved these changes
Nov 7, 2022
Added promote and publish commands again with all the flags so commands will not fail by unknown command or unknown flag. Instead these commands will show a deprecated message
jsoriano
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the references to Package Storage V1:
This PR also adds some tests to the status command about the local environment and pending changes not merged yet.
Example of output for the status subcommand:
To be merged after the switch to Package Storage V2.