-
Couldn't load subscription status.
- Fork 128
Add benchmark results comparison reports #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc2b4ee to
8c9761c
Compare
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it LGTM, added some small suggestions. Thanks!
- Keep an xml format - Rename source -> new, target -> old - Add report destination path flag - Generate report on benchmark test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions/suggestions, but LGTM.
scripts/test-check-packages.sh
Outdated
| rm -rf "${OLDPWD}/build/benchmark-results" | ||
| elastic-package benchmark -v --report-format xml --report-output file --fail-on-missing | ||
|
|
||
| rm -rf "${OLDPWD}/build/benchmark-results-old" | ||
| mv "${OLDPWD}/build/benchmark-results" "${OLDPWD}/build/benchmark-results-old" | ||
|
|
||
| elastic-package benchmark -v --report-format json --report-output file --fail-on-missing | ||
|
|
||
| elastic-package report --fail-on-missing benchmark --new ${OLDPWD}/build/benchmark-results --old ${OLDPWD}/build/benchmark-results-old --threshold 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. Could we also take the opportunity to test --report-output-path here?
| rm -rf "${OLDPWD}/build/benchmark-results" | |
| elastic-package benchmark -v --report-format xml --report-output file --fail-on-missing | |
| rm -rf "${OLDPWD}/build/benchmark-results-old" | |
| mv "${OLDPWD}/build/benchmark-results" "${OLDPWD}/build/benchmark-results-old" | |
| elastic-package benchmark -v --report-format json --report-output file --fail-on-missing | |
| elastic-package report --fail-on-missing benchmark --new ${OLDPWD}/build/benchmark-results --old ${OLDPWD}/build/benchmark-results-old --threshold 1 | |
| rm -rf "${OLDPWD}/build/benchmark-results" "${OLDPWD}/build/benchmark-results-old" | |
| elastic-package benchmark -v --report-format xml --report-output file --report-output-path "${OLDPWD}/build/benchmark-results-old" --fail-on-missing | |
| elastic-package benchmark -v --report-format json --report-output file --fail-on-missing | |
| elastic-package report --fail-on-missing benchmark --new ${OLDPWD}/build/benchmark-results --old ${OLDPWD}/build/benchmark-results-old --threshold 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm, tests still don't use --report-output-path? 🤔
report benchmarksubcommand that will allow to compare benchmark results between benchmark runs.Relates to #992
It will generate a Markdown report that will be used as part of CI results in
integrations:🚀 Benchmarks report
Package
aws👍(0) 💚(0) 💔(13)Expand to view
securityhub_findingssecurityhub_insightsvpcflowwafcloudfront_logscloudtrailcloudwatch_logsec2_logselb_logsfirewall_logsroute53_public_logsroute53_resolver_logss3accessTo see the full report comment with
/test benchmark fullreport