Add support for powershell in stack shellinit #1061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
commented
Dec 9, 2022
| case "pwsh", "powershell": | ||
| return `elastic-package stack shellinit | Invoke-Expression` | ||
| default: | ||
| return `eval "$(elastic-package stack shellinit)"` |
There was a problem hiding this comment.
@endorama is this syntax also used on fish?
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
/test |
mrodm
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested only on powershell on Linux, but I guess it is the same on Windows, I followed the documentation for Windows.
It adds support for powershell in
elastic-package stack shellinit, and also adds the help text when an error about a missing environment variable is reported. Shell is detected now on init when loading theinternal/stackmodule, to avoid having to add the--shellinit to all stack commands (but this could be another option).