-
Notifications
You must be signed in to change notification settings - Fork 127
Fix expected dataset check in test runners #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We do this check only with format_version >= 2.0.0. I will fix the test case. |
🌐 Coverage report
|
| @@ -1,15 +1,14 @@ | |||
| format_version: 1.0.0 | |||
| format_version: 2.2.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dataset checks are only executed for since 2.0.0.
|
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Data stream manifests can override the dataset, this is configured in the policy, but then when checking generated documents, it fails with:
Seen in elastic/integrations#4708.
Also fix issue that was silently skipping static tests for input packages, because they were looking for the sample event in the wrong path.