Skip to content

Conversation

@jsoriano
Copy link
Member

@jsoriano jsoriano commented Dec 15, 2022

Data stream manifests can override the dataset, this is configured in the policy, but then when checking generated documents, it fails with:

[0] field "data_stream.dataset" should have value "beat.stats", it has "beats.stack_monitoring.stats"
[1] field "event.dataset" should have value "beat.stats", it has "beats.stack_monitoring.stats"

Seen in elastic/integrations#4708.

Also fix issue that was silently skipping static tests for input packages, because they were looking for the sample event in the wrong path.

@jsoriano jsoriano requested a review from a team December 15, 2022 15:46
@jsoriano jsoriano self-assigned this Dec 15, 2022
@jsoriano
Copy link
Member Author

I wonder why this was not detected by the test case we have for this.

We do this check only with format_version >= 2.0.0. I will fix the test case.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 15, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-15T18:45:18.793+0000

  • Duration: 34 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 870
Skipped 0
Total 870

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 15, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (34/34) 💚
Files 67.188% (86/128) 👍
Classes 61.957% (114/184) 👍
Methods 48.705% (376/772) 👎 -0.063
Lines 31.906% (3406/10675) 👎 -0.03
Conditionals 100.0% (0/0) 💚

@jsoriano jsoriano changed the title Fix expected dataset in system tests Fix expected dataset in test runners Dec 15, 2022
@jsoriano jsoriano changed the title Fix expected dataset in test runners Fix expected dataset check in test runners Dec 15, 2022
@@ -1,15 +1,14 @@
format_version: 1.0.0
format_version: 2.2.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dataset checks are only executed for since 2.0.0.

@jsoriano
Copy link
Member Author

/test

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsoriano jsoriano merged commit 4e44f24 into elastic:main Dec 16, 2022
@jsoriano jsoriano deleted the expected-dataset-test branch December 16, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants