Remove stages related to tests from Jenkinsfile #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
3 tasks
mrodm
force-pushed
the
delete_stages_jenkinsfile
branch
from
b51546e to
43560e1
Compare
mrodm
force-pushed
the
delete_stages_jenkinsfile
branch
from
088bd96 to
cb5cf39
Compare
mrodm
commented
Feb 16, 2023
| JOB_GCS_EXT_CREDENTIALS = 'fleet-ci-gcs-plugin-file-credentials' | ||
| ELASTIC_PACKAGE_GCP_SECRET = 'secret/observability-team/ci/service-account/elastic-package-gcp' | ||
| ELASTIC_OBSERVABILITY_PROJECT_ID = 'elastic-observability' | ||
| BUILDKITE_MERGE_COMMIT = "79ee1738578deac17f8f5caf8d925db6244ab6df" |
There was a problem hiding this comment.
Commit reference for the merge commit where the buildkite pipeline was merged:
79ee173
mrodm
commented
Feb 16, 2023
| githubEnv() | ||
| r = sh(label: 'Check', returnStatus: true, script: ''' | ||
| echo "Base commit: ${GIT_BASE_COMMIT}" | ||
| git log --format=%H "${GIT_BASE_COMMIT}" | grep "${BUILDKITE_MERGE_COMMIT}" |
There was a problem hiding this comment.
Not able to check with git branch --contains command. So finally, it just checks the full log from the GIT_BASE_COMMIT
There was a problem hiding this comment.
Well, looks good. In any case this is temporary till we completely remove jenkins.
jsoriano
approved these changes
Feb 16, 2023
| githubEnv() | ||
| r = sh(label: 'Check', returnStatus: true, script: ''' | ||
| echo "Base commit: ${GIT_BASE_COMMIT}" | ||
| git log --format=%H "${GIT_BASE_COMMIT}" | grep "${BUILDKITE_MERGE_COMMIT}" |
There was a problem hiding this comment.
Well, looks good. In any case this is temporary till we completely remove jenkins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes stages related to tests (check static, unit tests and integration tests) to not be duplicated with the Buildkite plugin.
It replaces those stages to run a stage that checks whether or not the PR branch (GIT_BASE_COMMIT) contains the commit were the buildkite branch was merged. If the PR does not contain that changeset, a message is shown to the developer and the Jenkins build fails.
Tested with a PR created before the buildkite branch was merged: #1148
To be tested once it is merged to confirm that it works as expected with old PRs.