Fix search of repository root in Windows #1171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking for the repository root in Windows, if the command hasn't been called inside a git repository, the search will loop forever. Finalization condition is based on checking al parent directories till root, but root was checked with "/", that will never be the case in Windows. Changed to take into account the volume name and the OS-specific path separator.
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
jsoriano
force-pushed
the
find-repo-root-windows
branch
6 times, most recently
from
609795e to
c2c9511
Compare
Co-Authored-By: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
jsoriano
force-pushed
the
find-repo-root-windows
branch
from
c2c9511 to
89ef17a
Compare
mrodm
reviewed
Mar 7, 2023
mrodm
approved these changes
Mar 8, 2023
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking for the repository root in Windows, if the command hasn't been called inside a git repository, the search will loop forever, hanging the process. Same thing happens when looking for package root.
Finalization condition is based on checking all parent directories till root, but root was checked with "/", that will never be the case in Windows.
Changed to take into account the volume name and the OS-specific path separator.
Add step to buildkite pipeline to run unit tests on Windows.
Fixes #1100.