Skip to content

Conversation

@mrodm
Copy link
Contributor

@mrodm mrodm commented Mar 6, 2023

This PR adds the missing steps to sign and publish the given test package:

  • Triggering the corresponding Jenkins jobs to sign and publish packages
  • Added the required credentials into the pre-command hook

@mrodm mrodm self-assigned this Mar 6, 2023
@mrodm mrodm force-pushed the sign_publish_second_pipeline branch from 9ec6b1c to aed1851 Compare March 6, 2023 16:43
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-07T10:19:44.771+0000

  • Duration: 2 min 2 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mrodm mrodm requested a review from a team March 15, 2023 03:35
@mrodm mrodm marked this pull request as ready for review March 15, 2023 03:35
cleanup() {
echo "Deleting temporal files..."
cd ${WORKSPACE}
rm -rf tmp.elastic-package.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. Have a common base variable for the tmpdir folder pattern so we don't forget to update this if we change the template for mktemp?

Suggested change
rm -rf tmp.elastic-package.*
rm -rf ${TMP_FOLDER_TEMPLATE_BASE}.*


echo "Publishing package ${packageZip}"
publishPackage "${package}"
done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will something like this pipeline work to publish packages from integrations repositories?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, something like this script would be the steps to be used/followed in integrations (iterating for each package defined) or other repositories like endpoint-package or apm-server.

Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Comment on lines +29 to +30
SIGNING_PACKAGES_GCS_CREDENTIALS_PATH=kv/ci-shared/platform-ingest/signing_packages_gcs_artifacts_credentials
PACKAGE_UPLOADER_GCS_CREDENTIALS_PATH=kv/ci-shared/platform-ingest/package_storage_uploader
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to shared path and renamed variables

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mrodm

@mrodm mrodm changed the title Sign publish second pipeline Sign and publish pipeline in Buildkite Mar 16, 2023
@mrodm mrodm merged commit 69f430f into elastic:main Mar 16, 2023
@mrodm mrodm deleted the sign_publish_second_pipeline branch March 16, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants