Skip to content

Conversation

@mrodm
Copy link
Contributor

@mrodm mrodm commented Mar 7, 2023

Follow-up #1163

This PR adds the --skip-validation flag to the elastic-package install command.

By default, elastic-package install will validate the zip files before installing in the Kibana instance. Setting this new flag, this validation is skipped.

NOTE: This validation is just performed from Kibana>=8.7.0 where zip files are used. Previously, it is kept the same behavior.

This applies for both install directly a local zip file or running elastic-package install.

Some examples using elastic-package install --zip:

  • Running validation
 $ elastic-package install --zip ./elastic_package_registry-0.0.6.zip -v 
2023/03/08 18:15:02 DEBUG Enable verbose logging
2023/03/08 18:15:02 DEBUG Distribution built without a version tag, can't determine release chronology. Please consider using official releases at https://github.com/elastic/elastic-package/releases
2023/03/08 18:15:02 DEBUG GET https://127.0.0.1:5601/api/status
2023/03/08 18:15:02 DEBUG Validating built .zip package (path: ./elastic_package_registry-0.0.6.zip)
2023/03/08 18:15:02 DEBUG Skip validation of the built .zip package
2023/03/08 18:15:02 DEBUG Reading package manifest from ./elastic_package_registry-0.0.6.zip
Install zip package: ./elastic_package_registry-0.0.6.zip
2023/03/08 18:15:02 DEBUG POST https://127.0.0.1:5601/api/fleet/epm/packages
Installed assets:
- elastic_package_registry-313c2700-099b-11ed-91b6-3b1f9c2b2771 (type: dashboard)
- metrics-elastic_package_registry.metrics-0.0.6 (type: ingest_pipeline)
- metrics-elastic_package_registry.metrics (type: index_template)
- metrics-elastic_package_registry.metrics@package (type: component_template)
- metrics-elastic_package_registry.metrics@custom (type: component_template)
Done
  • Running without validation
 $ elastic-package install --zip ./elastic_package_registry-0.0.6.zip -v --skip-validation
2023/03/08 18:14:56 DEBUG Enable verbose logging
2023/03/08 18:14:56 DEBUG Distribution built without a version tag, can't determine release chronology. Please consider using official releases at https://github.com/elastic/elastic-package/releases
2023/03/08 18:14:56 DEBUG GET https://127.0.0.1:5601/api/status
2023/03/08 18:14:56 DEBUG Skip validation of the built .zip package
2023/03/08 18:14:56 DEBUG Reading package manifest from ./elastic_package_registry-0.0.6.zip
Install zip package: ./elastic_package_registry-0.0.6.zip
2023/03/08 18:14:56 DEBUG POST https://127.0.0.1:5601/api/fleet/epm/packages
Installed assets:
- elastic_package_registry-313c2700-099b-11ed-91b6-3b1f9c2b2771 (type: dashboard)
- metrics-elastic_package_registry.metrics-0.0.6 (type: ingest_pipeline)
- metrics-elastic_package_registry.metrics (type: index_template)
- metrics-elastic_package_registry.metrics@package (type: component_template)
- metrics-elastic_package_registry.metrics@custom (type: component_template)
Done

@mrodm mrodm self-assigned this Mar 7, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-07T11:55:07.789+0000

  • Duration: 2 min 26 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mrodm
Copy link
Contributor Author

mrodm commented Mar 7, 2023

/test

@mrodm mrodm marked this pull request as ready for review March 7, 2023 12:24
@mrodm mrodm requested a review from a team March 7, 2023 12:24
@mrodm mrodm marked this pull request as draft March 7, 2023 15:18
@mrodm mrodm changed the title Skip validation when building package in install Add skip validation flag in elastic-package install command Mar 8, 2023
@mrodm
Copy link
Contributor Author

mrodm commented Mar 8, 2023

/test

1 similar comment
@mrodm
Copy link
Contributor Author

mrodm commented Mar 8, 2023

/test

@mrodm mrodm marked this pull request as ready for review March 9, 2023 09:25
@mrodm mrodm requested a review from ruflin March 9, 2023 09:44
@mrodm mrodm merged commit 6db6600 into elastic:main Mar 10, 2023
@mrodm mrodm deleted the remove_validation_install branch March 10, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants