Skip to content

Conversation

@paolafrancesca
Copy link

@paolafrancesca paolafrancesca commented Mar 10, 2023

…v0.4.1

There was a bug in the corpus generator v0.4.0 that prevented corpora for datasets using the awsAZFromRegion function to be generated successfully

The bug was fixed in v0.4.1 and this PR bumps to that version

This PR changes as well the benchmark generate-corpus subcomand
Command example:

./elastic-package benchmark generate-corpus --commit 5ca23226adfe1b76869c5a1abc9428327b1a3a0b --dataset sqs --package aws --size 10K

The --data-stream flag was replaced with the more proper --dataset

It is now possible to generate directly a rally track:

./elastic-package benchmark generate-corpus --commit 5ca23226adfe1b76869c5a1abc9428327b1a3a0b --dataset sqs --package aws --size 10K --rally-track-output-dir ./track-folder

cc @ruflin

@paolafrancesca paolafrancesca requested a review from mrodm March 10, 2023 00:26
@paolafrancesca paolafrancesca self-assigned this Mar 10, 2023
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a comment about renaming the variable used for the dataset parameter.

@paolafrancesca
Copy link
Author

@mrodm please, look at the latest commits
thanks

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for updating the readme generator to include the subcommands! 👍

Use this command to generate benchmarks corpus data for a package.
Currently, only data for what we have related assets on https://github.com/elastic/elastic-integration-corpus-generator-tool are supported.
`
For details on how to run this command, review the [HOWTO guide](./docs/howto/generate_corpus.md).`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paolafrancesca paolafrancesca merged commit c668312 into elastic:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants