-
Notifications
You must be signed in to change notification settings - Fork 127
bump github.com/elastic/elastic-integration-corpus-generator-tool to … #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump github.com/elastic/elastic-integration-corpus-generator-tool to … #1180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a comment about renaming the variable used for the dataset parameter.
|
@mrodm please, look at the latest commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for updating the readme generator to include the subcommands! 👍
| Use this command to generate benchmarks corpus data for a package. | ||
| Currently, only data for what we have related assets on https://github.com/elastic/elastic-integration-corpus-generator-tool are supported. | ||
| ` | ||
| For details on how to run this command, review the [HOWTO guide](./docs/howto/generate_corpus.md).` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…v0.4.1
There was a bug in the corpus generator v0.4.0 that prevented corpora for datasets using the
awsAZFromRegionfunction to be generated successfullyThe bug was fixed in v0.4.1 and this PR bumps to that version
This PR changes as well the
benchmark generate-corpussubcomandCommand example:
The
--data-streamflag was replaced with the more proper--datasetIt is now possible to generate directly a rally track:
cc @ruflin