Skip to content

Update elastic/elastic-integration-corpus-generator-tool to v0.5.0 #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Update elastic/elastic-integration-corpus-generator-tool to v0.5.0 #1193

wants to merge 2 commits into from

Conversation

@endorama
Copy link
Contributor

@endorama endorama commented Mar 21, 2023 •
edited
Loading

Update dependency to latest release

https://github.com/elastic/elastic-integration-corpus-generator-tool/releases/tag/v0.5.0

Locally I had some tests failing (they were failing on main too):

  • internal/certs TestCA/validate_server_with_root_CA/curl (0.02s)
  • internal/certs TestCA/validate_server_with_root_CA (0.02s)
  • internal/certs TestCA/validate_server_with_intermediate_CA/curl (0.02s)
  • internal/certs TestCA/validate_server_with_intermediate_CA (0.02s)
  • internal/certs TestCA (0.05s)

cc @aspacca

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@jsoriano jsoriano requested a review from a team March 21, 2023 22:50
@paolafrancesca paolafrancesca requested a review from mrodm March 22, 2023 03:05
@paolafrancesca
Copy link

paolafrancesca commented Mar 22, 2023 •
edited
Loading

it seems dependantbot already took care of it: #1196

not sure why the diff still shows the change: main has the proper content https://github.com/elastic/elastic-package/blob/main/go.mod#L13

mrodm
mrodm reviewed Mar 22, 2023
View reviewed changes
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #1193 (comment)
The changes in this PR look like they were already by dependabot #1196

@endorama
Copy link
Contributor Author

Closing this, didn't know there was dependabot with auto merge enabled.

@endorama endorama closed this Mar 23, 2023
@endorama endorama mentioned this pull request Mar 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrodm mrodm mrodm left review comments

@jsoriano jsoriano Awaiting requested review from jsoriano

+1 more reviewer

@paolafrancesca paolafrancesca paolafrancesca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@endorama @elasticmachine @paolafrancesca @mrodm