Skip to content

Conversation

@jsoriano
Copy link
Member

elastic-package profiles use can be used to select the profile that will be used by default. This change includes some UI improvements around it.

  • Current profile is shown now in elastic-package profiles list.
  • If current profile is deleted, current profile is replaced by the default profile, that cannot be removed.
  • A confirmation message is shown now after changing the current profile.

How to test

  • Create a new profile (elastic-package profiles create test).
  • List profiles, and check that you can see what is the current profile (elastic-package profiles list).
  • Select the created profile as the current one (elastic-package profiles use test).
  • List profiles, and check that you can see that your profile is the current profile (elastic-package profiles list).
  • Delete the current profile (elastic-package profiles delete test).
  • List profiles, and check that the default profile is the current profile (elastic-package profiles list).

@jsoriano jsoriano requested a review from a team May 22, 2023 11:45
@jsoriano jsoriano self-assigned this May 22, 2023
`elastic-package profiles use` can be used to select the profile that
will be used by default. This change includes some UI improvements
around it.

* Current profile is shown now in `elastic-package profiles list`.
* If current profile is deleted, current profile is replaced by the
  default profile, that cannot be removed.
* A confirmation message is shown now after changing the current
  profile.
@jsoriano jsoriano force-pushed the profiles-list-current branch from bc31d94 to 72ea3bc Compare May 22, 2023 11:47
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @jsoriano

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Tested locally 👍

@jsoriano jsoriano merged commit b57cc2d into elastic:main May 26, 2023
@jsoriano jsoriano deleted the profiles-list-current branch May 26, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants