Explicitly install packages on system tests #1281
Conversation
This will allow to earlier detect if one is not testing the version they currently have in the working copy. From 8.7.0 version, it builds and install the zip package. On older versions it installs whatever is in the configured package registry. In that case, if the version of the package is not available in the repository, test execution will fail.
| return agents, nil | ||
| } | ||
|
|
||
| func installPackage(client *kibana.Client, manifest *packages.PackageManifest, rootPath string) error { |
There was a problem hiding this comment.
This looks similar to the factory created in cmd/install.go file. Do you think it would be possible to reuse some of the code? Maybe the installer code:
- for local packages: internal/packages/installer/installer.go
- for zip packages: internal/packages/installer/zip_installer.go
https://github.com/elastic/elastic-package/tree/main/internal/packages/installer
There was a problem hiding this comment.
I have merged both codes in a single factory in the installer package, let me know what you think.
I am also passing the kibana client from the callers, I would like to have more explicit initializations of the clients we use. This is something I have WIP to be able to get the settings from the profile in this branch https://github.com/elastic/elastic-package/compare/main...jsoriano:elastic-package:clients-from-profile?expand=1.
There was a problem hiding this comment.
I have merged both codes in a single factory in the installer package, let me know what you think.
It looks perfect! 💪 thanks for doing this change!
I am also passing the kibana client from the callers, I would like to have more explicit initializations of the clients we use. This is something I have WIP to be able to get the settings from the profile in this branch https://github.com/elastic/elastic-package/compare/main...jsoriano:elastic-package:clients-from-profile?expand=1.
Ok! that would also help us to add more tests if the kibana client is set as a parameter 👍
| return agents, nil | ||
| } | ||
|
|
||
| func installPackage(client *kibana.Client, manifest *packages.PackageManifest, rootPath string) error { |
There was a problem hiding this comment.
I have merged both codes in a single factory in the installer package, let me know what you think.
It looks perfect! 💪 thanks for doing this change!
I am also passing the kibana client from the callers, I would like to have more explicit initializations of the clients we use. This is something I have WIP to be able to get the settings from the profile in this branch https://github.com/elastic/elastic-package/compare/main...jsoriano:elastic-package:clients-from-profile?expand=1.
Ok! that would also help us to add more tests if the kibana client is set as a parameter 👍
| if err != nil { | ||
| return result.WithError(fmt.Errorf("failed to install package: %v", err)) | ||
| } | ||
| r.deletePackageHandler = func() error { |
There was a problem hiding this comment.
I couldn't just use defer here, I needed to use a handler to play well with the tear downs here.
💚 Build Succeeded
History
cc @jsoriano |
3 participants
This will allow to earlier detect if one is not testing the version they currently have in the working copy.
From 8.7.0 version, it builds and install the zip package. On older versions it installs whatever is in the configured package registry. In that case, if the version of the package is not available in the repository, test execution will fail.
Also removes uses of
errors.Wrapin the file.It won't be tested in CI till stack version is updated to >= 8.7.0.