Ensure that required commands are run for test benchmark packages #1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check which package is being tested in case of benchmark suite, but keeping all these test packages in the same step.
This reverts commit 65f88fe.
jsoriano
approved these changes
Jun 28, 2023
mrodm
commented
Jun 28, 2023
scripts/test-check-packages.sh
Outdated
| fi | ||
| if [ "${PACKAGE_UNDER_TEST:-*}" == "system_benchmark" ]; then | ||
| if [ "${package_to_test}" == "system_benchmark" ]; then | ||
| elastic-package benchmark system --benchmark logs-benchmark -v --defer-cleanup 1s |
There was a problem hiding this comment.
@marc-gr now that these tests are being run, system_benchmark package is failing with several errors:
Could we comment out for the time being this command ?
mrodm
changed the title
|
/test |
marc-gr
approved these changes
Jun 29, 2023
💚 Build Succeeded
History
cc @mrodm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the parameter
-pin order to set thePACKAGE_UNDER_TESTvariable for benchmark packages.Required for the integrations shell script to run those tests:
elastic-package/scripts/test-check-packages.sh
Line 72 in 57d0c6f