Skip to content

Conversation

@mrodm
Copy link
Contributor

@mrodm mrodm commented Jun 28, 2023

This PR removes unnecessary docker-compose logs from the output for both docker-compose v1 and docker-compose v2.

This is enabled when these variables are set as true:

  • ELASTIC_PACKAGE_COMPOSE_DISABLE_ANSI (it was already available)
  • ELASTIC_PACKAGE_COMPOSE_DISABLE_PULL_PROGRESS_INFORMATION
    • It removes all the logs like
46e21c7cfe17 Pulling fs layer
46e21c7cfe17 Waiting
3062453c23d0 Downloading [==================================================>]     456B/456B
3062453c23d0 Download complete
28d3cd0c3ee3 Downloading [==================================================>]     451B/451B
28d3cd0c3ee3 Download complete
69000b67186e Downloading [>                                                  ]  392.7kB/38.93MB
8d2cded47a25 Downloading [>                                                  ]  327.2kB/31.79MB
8d2cded47a25 Downloading [>                                                  ]  327.2kB/31.79MB
27534c8e9e3f Downloading [>                                                  ]  536.7kB/490.6MB
69000b67186e Downloading [==============>                                    ]  11.01MB/38.93MB
8d2cded47a25 Downloading [================>                                  ]  10.49MB/31.79MB
8d2cded47a25 Downloading [================>                                  ]  10.49MB/31.79MB
27534c8e9e3f Downloading [=>                                                 ]  11.21MB/490.6MB

It also removes a redundant log message from elastic-package stack status

@mrodm mrodm self-assigned this Jun 28, 2023
@mrodm mrodm requested a review from a team June 28, 2023 16:27
@mrodm mrodm marked this pull request as ready for review June 28, 2023 16:27
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mrodm

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just be sure that we don't break V1.

@mrodm mrodm merged commit 8a95967 into elastic:main Jul 4, 2023
@mrodm mrodm deleted the clean_output_docker_compose branch July 4, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants