Re-wrap errors #1332
Merged
Re-wrap errors #1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
💚 Build Succeeded
History
cc @jsoriano |
mrodm
approved these changes
Jun 29, 2023
efd6
reviewed
Jun 29, 2023
Comment on lines
110
to
112
| if len(node.Content) == 0 || node.Content[0].Kind != yaml.MappingNode { | ||
| return nil, errors.Wrap(err, "unexpected manifest content") | ||
| return nil, fmt.Errorf("unexpected manifest content: %w", err) | ||
| } |
There was a problem hiding this comment.
This is not right; err is nill here but this returns a non-nil error referring to err.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use standard library for errors wrapping.
Most code changes done with
github.com/xdg-go/go-rewrap-errorsandgoimports.Steps followed to prepare this PR:
find . -name "*.go" -exec go run github.com/xdg-go/go-rewrap-errors@latest -w {} \;find . -name "*.go" -exec goimports -w {} \;go mod tidylog.Fatal(fmt.Errorfwithlog.Fatalf(...(not really related, but took the opportunity to fix this).make check-static, and fix linting issues related to error messages.errors.Wrapwould have returned nil (6993819).