Skip to content

Conversation

@jillguyonnet
Copy link
Contributor

Fixes #1348

The Kibana version constraint of the experimentalDataStreamSettings was amended in #1328 to version > 8.7.0 and < 8.10.0. However, this fails for version 8.10.0-SNAPSHOT which is lower than 8.10.0.

This PR fixes the constraint and adds a unit test to the TestSemverLessThan function.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 10, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

History

@jlind23 jlind23 requested review from jsoriano and mrodm July 10, 2023 17:20
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@jillguyonnet jillguyonnet merged commit a699d90 into elastic:main Jul 11, 2023
@jillguyonnet jillguyonnet deleted the fleet/fix-version-constraint-for-experimentalDataStreamSettings branch July 11, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"experimentalDataStreamSettings" configuration not allowed in 8.10.0-SNAPSHOT

3 participants