Skip to content

Conversation

@jsoriano
Copy link
Member

@jsoriano jsoriano commented Aug 8, 2023

Avoid modifying pipelines when unmarshalling them to add reroute rules. For that,
unmarshal them to a generic map, instead to a struct with limited fields.

@jsoriano jsoriano requested a review from kaiyan-sheng August 8, 2023 15:53
@jsoriano jsoriano self-assigned this Aug 8, 2023
@jsoriano
Copy link
Member Author

jsoriano commented Aug 8, 2023

test integrations

@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#7312

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing it!!

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @jsoriano

@jsoriano
Copy link
Member Author

jsoriano commented Aug 9, 2023

Merging as failures seen in elastic/integrations#7312 don't seem to be related.

@jsoriano jsoriano merged commit 152bbac into elastic:main Aug 9, 2023
@jsoriano jsoriano deleted the fix-pipeline-tests-routing-rules branch August 9, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants