Skip to content

fix the GCP credentials variable name #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2023
Merged

fix the GCP credentials variable name #1394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .buildkite/scripts/tooling.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ google_cloud_auth() {

gcloud auth activate-service-account --key-file ${keyFile} 2> /dev/null

export GOOGLE_APPLICATIONS_CREDENTIALS=${secretFileLocation}
export GOOGLE_APPLICATION_CREDENTIALS=${secretFileLocation}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing to rename also the unset command here @sharbuz

elastic-package/.buildkite/scripts/integration_tests.sh

Line 95 in c4cc6b1

unset GOOGLE_APPLICATIONS_CREDENTIALS

}

retry() {
Expand All @@ -44,4 +44,3 @@ retry() {
done
return 0
}