Skip to content

Conversation

@jsoriano
Copy link
Member

@jsoriano jsoriano commented Aug 25, 2023

For packages that have transforms, check that they are collecting valid documents.

Fix #1402.

@jsoriano jsoriano self-assigned this Aug 25, 2023
@jsoriano
Copy link
Member Author

test integrations

@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#7561

@jsoriano jsoriano marked this pull request as ready for review August 28, 2023 12:51
@jsoriano jsoriano requested a review from a team August 28, 2023 12:51
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have validation around transforms too!

Comment on lines +731 to +733
if err := r.checkTransforms(config, pkgManifest, ds, dataStream); err != nil {
return result.WithError(err)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it's not needed. I was wondering if at the end of the system test execution we should delete the indices created by the transforms.
Something similar to what it's done here for the main data stream

r.wipeDataStreamHandler = func() error {
logger.Debugf("deleting data in data stream...")
if err := deleteDataStreamDocs(r.options.API, dataStream); err != nil {
return fmt.Errorf("error deleting data in data stream: %w", err)
}
return nil
}

Or maybe it's better to leave that management to Fleet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it wouldn't be needed because the source data is already deleted. The transform should be deleted by Fleet, but I think it is not doing it.

@jsoriano
Copy link
Member Author

/test

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @jsoriano

@jsoriano jsoriano merged commit 60ee154 into elastic:main Aug 29, 2023
@jsoriano jsoriano deleted the test-transforms branch August 29, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check mappings for indices created by Elasticsearch transform

3 participants