-
Notifications
You must be signed in to change notification settings - Fork 127
Check transforms in packages that have them #1409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
test integrations |
|
Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#7561 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have validation around transforms too!
| if err := r.checkTransforms(config, pkgManifest, ds, dataStream); err != nil { | ||
| return result.WithError(err) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably it's not needed. I was wondering if at the end of the system test execution we should delete the indices created by the transforms.
Something similar to what it's done here for the main data stream
elastic-package/internal/testrunner/runners/system/runner.go
Lines 552 to 558 in 3295997
| r.wipeDataStreamHandler = func() error { | |
| logger.Debugf("deleting data in data stream...") | |
| if err := deleteDataStreamDocs(r.options.API, dataStream); err != nil { | |
| return fmt.Errorf("error deleting data in data stream: %w", err) | |
| } | |
| return nil | |
| } |
Or maybe it's better to leave that management to Fleet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think it wouldn't be needed because the source data is already deleted. The transform should be deleted by Fleet, but I think it is not doing it.
|
/test |
💚 Build Succeeded
History
cc @jsoriano |
For packages that have transforms, check that they are collecting valid documents.
Fix #1402.