Review positional arguments in commands #1415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reviews usage of positional arguments in all commands and sub-commands.
Currently, if a positional argument is set in the command line, this parameter is ignored. I think that could be misleading.
This PR enforces to not use positional arguments if they are not needed.
As an example:
In case of
elastic-package testandelastic-package benchmarkcommands the same positional arguments has been kept. Keeping that would show a more specific error for those commands.Example:
cobra.NoArgs: