Add support to filter errors in packages based on codes #1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
force-pushed
the
add_filter_errors_packages
branch
from
3bd1eeb to
246577f
Compare
mrodm
changed the title
|
buildkite test this |
1 similar comment
|
buildkite test this |
jsoriano
reviewed
Sep 27, 2023
cmd/lint.go
Outdated
| return fmt.Errorf("linting package failed: %w", err) | ||
| errs, skipped := validation.ValidateAndFilterFromPath(packageRootPath) | ||
| if skipped != nil { | ||
| logger.Infof("skipped errors: %v", skipped) |
There was a problem hiding this comment.
Should we log these at the warning level instead?
internal/validation/validation.go
Outdated
| return allErrors, nil, nil | ||
| } | ||
|
|
||
| config, err := processors.LoadConfigFilter(fsys, configPath) |
There was a problem hiding this comment.
I still see this "processors" name as a too generic name, specially when used externally, but lets continue with it.
There was a problem hiding this comment.
Just changed all the code in processors to be in the same specerrors.
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
💚 Build Succeeded
History
cc @mrodm |
mrodm
commented
Sep 29, 2023
| @@ -0,0 +1,45 @@ | |||
| # HOWTO: Filter errors based on Validation Codes | |||
There was a problem hiding this comment.
Added doc about how filtering errors should be set up.
|
Updated with the latest package-spec version and added a new doc about how to filter errors based on the codes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates elastic/package-spec#558
This PR adds the required support to filter errors based on the errors configuration (
errors.ymlvalidation.yml) for both directories and zip packages.This PR depends on a new package-spec version including the structured errors.