Accept null as array #1501
Accept null as array #1501
Conversation
|
/test |
1 similar comment
|
/test |
💔 Build Failed
Failed CI StepsHistory
cc @jsoriano |
| Fields: []FieldDefinition{ | ||
| { | ||
| Name: "id", | ||
| Type: "keyword", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Should this be an empty array ?
There was a problem hiding this comment.
An empty array would work. The problem solved here is when a field defined as group or nested is null in a document, like onepassword.details here elastic/integrations@09a01f2#diff-76a51622c000706ccf925266e2e1255f954f7b55380135342a9d51aa3b81b5cdL55
There was a problem hiding this comment.
Ok, I misunderstood the definition field. I thought it was resulting definition built.
Just to be sure, it's being compared the value nil of a field null_array against that definition/schema in definition. Would that be right?
There was a problem hiding this comment.
Yes, this would be like validating a document with this JSON content:
{
"null_array": null
}
With this fields definition:
- name: null_array
type: group
fields: ...
Validation fails without this change.
|
Failure in AWS test package seems unrelated, merging. |
3 participants
Accept
nullin test documents for values when an array of objects is expected.