Skip to content

Conversation

@chrisberkhout
Copy link
Contributor

Currently, a system benchmark run started from the package root as follows:

elastic-package benchmark system --benchmark logs-benchmark

Will load the scenario defined in:

<package root>/_dev/benchmark/system/logs-benchmark.yml

This PR allows loading system benchmark scenarios from elsewhere on the filesystem by adding a --path option to the elastic-package benchmark system command.

This system benchmark run:

elastic-package benchmark system --benchmark logs-benchmark --path /tmp/scenariodirectory

Will load the scenario defined in:

/tmp/scenariodirectory/logs-benchmark.yml

The change includes loading other related files correctly, including from the deploy/ subdirectory.

Related issues

@chrisberkhout
Copy link
Contributor Author

/test

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsoriano
Copy link
Member

There is a CI failure in benchmark tests, could it be related to this change?

@chrisberkhout
Copy link
Contributor Author

/test

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @chrisberkhout

@chrisberkhout
Copy link
Contributor Author

There is a CI failure in benchmark tests, could it be related to this change?

The last change exposed an earlier issue. Now fixed.

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chrisberkhout chrisberkhout merged commit 0c9d174 into elastic:main Dec 20, 2023
@chrisberkhout chrisberkhout deleted the bench-sys-scenarios-from-elsewhere branch December 20, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants