-
Notifications
You must be signed in to change notification settings - Fork 127
Add --path option for loading system benchmark scenarios from elsewhere #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --path option for loading system benchmark scenarios from elsewhere #1603
Conversation
|
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
There is a CI failure in benchmark tests, could it be related to this change? |
|
/test |
💚 Build Succeeded
History
|
The last change exposed an earlier issue. Now fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Currently, a system benchmark run started from the package root as follows:
Will load the scenario defined in:
This PR allows loading system benchmark scenarios from elsewhere on the filesystem by adding a
--pathoption to theelastic-package benchmark systemcommand.This system benchmark run:
Will load the scenario defined in:
The change includes loading other related files correctly, including from the
deploy/subdirectory.Related issues