Skip to content

[Buildkite] Revamp buildkite scripts #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 19, 2023
Merged

[Buildkite] Revamp buildkite scripts #1606

merged 3 commits into from
Dec 19, 2023

Conversation

@mrodm
Copy link
Contributor

@mrodm mrodm commented Dec 19, 2023 •
edited
Loading

Update buildkite scripts

Tested:

@mrodm mrodm requested review from a team and sharbuz December 19, 2023 10:41
@mrodm mrodm self-assigned this Dec 19, 2023
@mrodm
Copy link
Contributor Author

mrodm commented Dec 19, 2023

test integrations

@elasticmachine elasticmachine mentioned this pull request Dec 19, 2023
Closed
@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repository to test this version. Check elastic/integrations#8752

@mrodm
Copy link
Contributor Author

mrodm commented Dec 19, 2023

test integrations

@mrodm
Copy link
Contributor Author

mrodm commented Dec 19, 2023

test integrations

@elasticmachine elasticmachine mentioned this pull request Dec 19, 2023
Closed
@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repository to test this version. Check elastic/integrations#8753

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mrodm

sharbuz
sharbuz approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@sharbuz sharbuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you @mrodm !
I only have one proposal: If we are going to use the common library of scripts I would start using universal (depending on the environment architecture) functions for installing some kind of tools where it's possible to avoid hardcoded "Linux", "x86_64" and so forth...

@mrodm
Copy link
Contributor Author

mrodm commented Dec 19, 2023 •
edited
Loading

I only have one proposal: If we are going to use the common library of scripts I would start using universal (depending on the environment architecture) functions for installing some kind of tools where it's possible to avoid hardcoded "Linux", "x86_64" and so forth...

I'll create a follow PR for this @sharbuz ,thanks for the heads up!

EDIT:
Created PR #1608

@mrodm mrodm merged commit 42a15e6 into elastic:main Dec 19, 2023
@mrodm mrodm deleted the refactor_buildkite_scripts branch December 19, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

+1 more reviewer

@sharbuz sharbuz sharbuz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mrodm mrodm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrodm @elasticmachine @jsoriano @sharbuz