Skip to content

Fix runner shutdown, improve error message #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Fix runner shutdown, improve error message #1609

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
918a39d
Fix runner shutdown, improve error message
ruflin Dec 20, 2023
d3139e7
Update internal/benchrunner/runners/stream/runner.go
ruflin Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/benchrunner/runners/stream/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,8 @@ func (r *runner) collectBulkRequestBody(indexName, scenarioName string, buf *byt
var event map[string]any
err = json.Unmarshal(buf.Bytes(), &event)
if err != nil {
return bulkBodyBuilder, err
logger.Debugf("Problem found when unmarshalling document: %s", buf.String())
return bulkBodyBuilder, fmt.Errorf("failed to unmarshal json event, check your benchmark template for scenario %s: %w", scenarioName, err)
}
enriched := r.enrichEventWithBenchmarkMetadata(event)
src, err := json.Marshal(enriched)
Expand Down Expand Up @@ -505,6 +506,7 @@ func (r *runner) streamData() {

if err != nil {
r.errChanGenerators <- fmt.Errorf("error while generating event for streaming: %w", err)
return
}
}

Expand Down Expand Up @@ -534,6 +536,7 @@ func (r *runner) streamData() {

if err != nil {
r.errChanGenerators <- fmt.Errorf("error while generating event for streaming: %w", err)
return
}
}

Expand Down