Support system benchmarking with the logstash-output in the benchmarking agent policies #1615
Conversation
bhapas
added
enhancement
|
|
||
| // Assign the data_output_id to the agent policy to configure the output to logstash. The value is inferred from stack/_static/kibana.yml.tmpl | ||
| if r.options.Profile.Config("stack.logstash_enabled", "false") == "true" { | ||
| p.DataOutputID = "fleet-logstash-output" |
There was a problem hiding this comment.
Could we add a test for this case?
There was a problem hiding this comment.
@jsoriano You mean a test package? The test-check-packages has regular benchmarks being tested. Should we add another package like benchmarks-with-logstash?
There was a problem hiding this comment.
It would be a test that runs benchmarks with logstash, it can be a new package or a new script and an existing package, not sure what would be the best approach.
There was a problem hiding this comment.
I can add a regression test. As currently logstash does not provide relevant stats that are comparable to ingest node stats. But I just want to make sure we can run system benchmarks even with logstash enabled.
There was a problem hiding this comment.
@jsoriano Added a test package
bhapas
force-pushed
the
logstash-benchmark
branch
2 times, most recently
from
983edad to
57f0264
Compare
bhapas
force-pushed
the
logstash-benchmark
branch
from
57f0264 to
9aef4d8
Compare
💚 Build Succeeded
History
cc @bhapas |
3 participants
Support system benchmarking with the logstash-output in the benchmarking agent policies.
If
stack.logstash_enabled: trueis set in the current profile's config use the logstash output over the default.