Skip to content

Conversation

@mrodm
Copy link
Contributor

@mrodm mrodm commented Jan 22, 2024

Update default Elastic version up to 8.11.4.
Update also the Elastic snapshot version used for tests to 8.12-SNAPSHOT

Error found in packages related to updating the Elastic stack version (build link):

EDIT: changes moved to another PR #1639

This PR also updates step to test profiles to use Container agent (k8s) instead of a GCP agent.

Errors in test packages (build link):

  • system: Updated test package up to the latest version in integrations
  • apache. Error found:
    error fetching data: error making http request: Get "http://elastic-package-service-apache-1:80/server-status?auto=": dial tcp 172.18.0.6:80: i/o timeout
    • Downgrade docker daemon to version 24.0.7
  • sql_input. Error found:
    cannot open connection: testing connection: dial tcp 172.18.0.4:3306: connect: no route to host
    • Downgrade docker daemon to version 24.0.7

Changes tested:

@mrodm mrodm requested a review from a team January 22, 2024 11:55
@mrodm mrodm self-assigned this Jan 22, 2024
@mrodm
Copy link
Contributor Author

mrodm commented Jan 22, 2024

buildkite test this

@mrodm
Copy link
Contributor Author

mrodm commented Jan 22, 2024

buildkite test this

@mrodm mrodm changed the title Update default stack versions Update default stack versions - WIP Jan 22, 2024
@mrodm
Copy link
Contributor Author

mrodm commented Jan 22, 2024

buildkite test this

1 similar comment
@mrodm
Copy link
Contributor Author

mrodm commented Jan 23, 2024

buildkite test this

@mrodm
Copy link
Contributor Author

mrodm commented Jan 23, 2024

It looks like that all these tests failing due to connectivity errors or timeouts are related to a new docker version published on 19th January (25.0.0) and it has been updated also in the base image used for our GCP agents.

After testing different approaches (updated in the description), it has been downgraded the docker daemon to the previous version 24.0.7 (docker-ce and docker-ce-cli packages) and hardcode the docker compose version used in the pipelines (2.24.1)

@mrodm
Copy link
Contributor Author

mrodm commented Jan 23, 2024

buildkite test this

@mrodm mrodm requested review from jlind23 and jsoriano January 23, 2024 12:21
@mrodm mrodm changed the title Update default stack versions - WIP Update default stack versions Jan 23, 2024
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for solving this! I wonder if we should split this PR in two, one for the docker changes and another one for the update of the stack.
But it also looks good to me like this.

Comment on lines 5 to 6
DOCKER_COMPOSE_VERSION: "v2.24.1"
DOCKER_VERSION: "24.0.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker compose in docker 24 is also fine, right? But well, given the problems we are finding it may be better to control both versions, as you prefer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I prefer to pin both versions so we can manage them as we require.

Comment on lines 83 to 85
retry 5 curl -SL -o ${DOCKER_CONFIG}/docker-compose "https://github.com/docker/compose/releases/download/${DOCKER_COMPOSE_VERSION}/docker-compose-${platform_type_lowercase}-${hw_type}"
chmod +x ${DOCKER_CONFIG}/docker-compose
docker compose version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this replace the compose plugin included in docker package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested here setting docker compose version 2.19.1, and it works as expected.
https://buildkite.com/elastic/elastic-package/builds/2197#018d36ce-9724-40f6-bcb4-d50d6dfaedaf/213-376

IMHO as there is a version set in ~/.docker/cli-plugins , it would be that one instead of the installed one using debian packages. Not 100% sure, but at least if it is changed the version, it uses the binary (version) in that folder.

sudo systemctl start docker
}

with_docker_compose() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not, it has been replaced by the one installing it as a plugin.

@mrodm
Copy link
Contributor Author

mrodm commented Jan 23, 2024

Great, thanks for solving this! I wonder if we should split this PR in two, one for the docker changes and another one for the update of the stack.
But it also looks good to me like this.

Ok, I'll separate the PRs 👍
Create separated PR to downgrade docker #1639

@mrodm mrodm mentioned this pull request Jan 23, 2024
2 tasks
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mrodm

@mrodm mrodm merged commit f02cbfb into elastic:main Jan 23, 2024
@mrodm mrodm deleted the update_default_stack_to_8.11 branch January 23, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants