-
Notifications
You must be signed in to change notification settings - Fork 127
Update default stack versions #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
buildkite test this |
|
buildkite test this |
|
buildkite test this |
1 similar comment
|
buildkite test this |
|
It looks like that all these tests failing due to connectivity errors or timeouts are related to a new docker version published on 19th January ( After testing different approaches (updated in the description), it has been downgraded the docker daemon to the previous version 24.0.7 ( |
|
buildkite test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for solving this! I wonder if we should split this PR in two, one for the docker changes and another one for the update of the stack.
But it also looks good to me like this.
| DOCKER_COMPOSE_VERSION: "v2.24.1" | ||
| DOCKER_VERSION: "24.0.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker compose in docker 24 is also fine, right? But well, given the problems we are finding it may be better to control both versions, as you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I prefer to pin both versions so we can manage them as we require.
| retry 5 curl -SL -o ${DOCKER_CONFIG}/docker-compose "https://github.com/docker/compose/releases/download/${DOCKER_COMPOSE_VERSION}/docker-compose-${platform_type_lowercase}-${hw_type}" | ||
| chmod +x ${DOCKER_CONFIG}/docker-compose | ||
| docker compose version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this replace the compose plugin included in docker package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested here setting docker compose version 2.19.1, and it works as expected.
https://buildkite.com/elastic/elastic-package/builds/2197#018d36ce-9724-40f6-bcb4-d50d6dfaedaf/213-376
IMHO as there is a version set in ~/.docker/cli-plugins , it would be that one instead of the installed one using debian packages. Not 100% sure, but at least if it is changed the version, it uses the binary (version) in that folder.
.buildkite/scripts/install_deps.sh
Outdated
| sudo systemctl start docker | ||
| } | ||
|
|
||
| with_docker_compose() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not, it has been replaced by the one installing it as a plugin.
Ok, I'll separate the PRs 👍 |
💚 Build Succeeded
History
cc @mrodm |
Update default Elastic version up to
8.11.4.Update also the Elastic snapshot version used for tests to
8.12-SNAPSHOTError found in packages related to updating the Elastic stack version (build link):
system: Updated test package up to the latest version in integrationsEDIT: changes moved to another PR #1639
This PR also updates step to test profiles to use Container agent (k8s) instead of a GCP agent.
Errors in test packages (build link):
system: Updated test package up to the latest version in integrationsapache. Error found:error fetching data: error making http request: Get "http://elastic-package-service-apache-1:80/server-status?auto=": dial tcp 172.18.0.6:80: i/o timeoutsql_input. Error found:cannot open connection: testing connection: dial tcp 172.18.0.4:3306: connect: no route to hostChanges tested: