Logstash improvements: auto pipeline reload. #1668
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,38 @@ | ||||||
| #!/bin/bash | ||||||
|
|
||||||
| set -euo pipefail | ||||||
|
|
||||||
| LOGSTASH_HOME="/usr/share/logstash/" | ||||||
|
|
||||||
| # logstash expects the key in pkcs8 format. | ||||||
| # Hence converting the key.pem to pkcs8 format using openssl. | ||||||
| create_cert() { | ||||||
| ls_cert_path="$LOGSTASH_HOME/config/certs" | ||||||
| openssl pkcs8 -inform PEM -in "$ls_cert_path/key.pem" -topk8 -nocrypt -outform PEM -out "/tmp/logstash.pkcs8.key" | ||||||
| chmod 777 "/tmp/logstash.pkcs8.key" | ||||||
|
Comment on lines
+11
to
+12
There was a problem hiding this comment. Nit. It doesn't use to be a good practice to write a key in There was a problem hiding this comment. Sounds good! Let me follow up Nits with separate PR because this is somehow blocking my another task: elastic/logstash-filter-elastic_integration#122 (comment) |
||||||
| } | ||||||
|
|
||||||
| # config copy is intentional that mounted volumes will be busy and cannot be overwritten | ||||||
| overwrite_pipeline_config() { | ||||||
| ls_pipeline_config_path="$LOGSTASH_HOME/pipeline/" | ||||||
| cat "$ls_pipeline_config_path/generated_logstash.conf" > "$ls_pipeline_config_path/logstash.conf" | ||||||
| } | ||||||
|
|
||||||
| # installs the given plugin if it is not installed | ||||||
| install_plugin_if_missing() { | ||||||
| plugin_name=$1 | ||||||
| if [[ ! $(bin/logstash-plugin list) == *"$plugin_name"* ]]; then | ||||||
| echo "Missing plugin $plugin_name, installing now" | ||||||
| bin/logstash-plugin install "$plugin_name" | ||||||
| fi | ||||||
| } | ||||||
|
|
||||||
| # runs Logstash | ||||||
| run() { | ||||||
| bin/logstash -f "$LOGSTASH_HOME/pipeline/logstash.conf" --config.reload.automatic | ||||||
|
There was a problem hiding this comment. Nit. Could we use exec to replace the process?
Suggested change
|
||||||
| } | ||||||
|
|
||||||
| create_cert | ||||||
| overwrite_pipeline_config | ||||||
| install_plugin_if_missing "logstash-filter-elastic_integration" | ||||||
| run | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks!