Skip to content

Conversation

@jsoriano
Copy link
Member

@jsoriano jsoriano commented Feb 9, 2024

Configure elastic-agent by default with an empty policy to avoid affecting tests with uncontrolled versions of the system package. A new user parameter stack.self_monitor_enabled can be set to true to revert back to the previous behaviour.

We are configuring monitoring and the system package for the default policy in Elastic Agent managed by elastic-package stack, but this is not required for tests or package development, and it slightly slows down startup, consumes resources unnecessarily and is a source of flakiness.

For example in #1670 the tests for the system package are affected by the pre-installed system package. They are failing because a missing pipeline for system package 1.53.1, but the version being tested is 1.53.0.

pipeline with id [metrics-system.memory-1.53.1] does not exist

@jsoriano jsoriano self-assigned this Feb 9, 2024
@jsoriano jsoriano requested a review from a team February 9, 2024 18:34
@jsoriano
Copy link
Member Author

jsoriano commented Feb 9, 2024

test integrations

@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repository to test this version. Check elastic/integrations#9116

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just some minor comments.

jsoriano and others added 3 commits February 12, 2024 13:30
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @jsoriano

@jsoriano jsoriano merged commit d46c82d into elastic:main Feb 12, 2024
@jsoriano jsoriano deleted the elastic-agent-self-monitoring branch February 12, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants