-
Notifications
You must be signed in to change notification settings - Fork 127
Disable elastic agent self monitoring by default #1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jsoriano
merged 6 commits into
elastic:main
from
jsoriano:elastic-agent-self-monitoring
Feb 12, 2024
Merged
Disable elastic agent self monitoring by default #1672
jsoriano
merged 6 commits into
elastic:main
from
jsoriano:elastic-agent-self-monitoring
Feb 12, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test integrations |
jsoriano
commented
Feb 9, 2024
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#9116 |
mrodm
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just some minor comments.
Co-authored-by: Mario Rodriguez Molins <marrodmo@gmail.com>
💚 Build Succeeded
History
cc @jsoriano |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure elastic-agent by default with an empty policy to avoid affecting tests with uncontrolled versions of the system package. A new user parameter
stack.self_monitor_enabledcan be set to true to revert back to the previous behaviour.We are configuring monitoring and the system package for the default policy in Elastic Agent managed by
elastic-package stack, but this is not required for tests or package development, and it slightly slows down startup, consumes resources unnecessarily and is a source of flakiness.For example in #1670 the tests for the system package are affected by the pre-installed system package. They are failing because a missing pipeline for system package 1.53.1, but the version being tested is 1.53.0.