Skip to content

Update reset credentials API endpoint #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2024
Merged

Update reset credentials API endpoint #1673

merged 1 commit into from
Feb 12, 2024

Conversation

@mrodm
Copy link
Contributor

@mrodm mrodm commented Feb 12, 2024 •
edited
Loading

Update endpoint used to reset credentials when a Serverless project is created.

  • Test creating a new Serverless project
  • Check credentials
  • Test installing package and run some (system or pipeline) tests

@mrodm mrodm requested a review from a team February 12, 2024 15:21
@mrodm mrodm self-assigned this Feb 12, 2024
mrodm
mrodm commented Feb 12, 2024
View reviewed changes
internal/serverless/client.go

var (
elasticCloudApiKeyEnv = "EC_API_KEY"
elasticCloudAPIKeyEnv = "EC_API_KEY"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed as suggested by the editor linting.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mrodm

@mrodm mrodm merged commit f025a06 into elastic:main Feb 12, 2024
@mrodm mrodm deleted the change_serverless_api_credentials branch February 12, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@mrodm mrodm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrodm @elasticmachine @jsoriano