Skip to content

Remove TODO comment about test assets in input packages #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Remove TODO comment about test assets in input packages #1675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions internal/packages/assets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,7 @@ func loadElasticsearchAssets(pkgRootPath string) ([]Asset, error) {
}
}

// TODO add assets for input packages

// No Elasticsearch asset is created when an Input package is installed through the API.
return assets, nil
}

Expand Down
7 changes: 7 additions & 0 deletions internal/testrunner/runners/asset/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,13 @@ func (r *runner) run() ([]testrunner.TestResult, error) {
return nil
}

// No Elasticsearch asset is created when an Input package is installed through the API.
// This would require to create a Agent policy and add that input package to the Agent policy.
// As those input packages could have some required fields, it would also require to add
// configuration files as in system tests to fill those fields.
// In these tests, mainly it is required to test Kibana assets, therefore it is not added
// support for Elasticsearch assets in input packages.
// Related issue: https://github.com/elastic/elastic-package/issues/1623
expectedAssets, err := packages.LoadPackageAssets(r.packageRootPath)
if err != nil {
return result.WithError(fmt.Errorf("could not load expected package assets: %w", err))
Expand Down