Provide contexts to kibana methods #1713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
changed the title
1 task
mrodm
reviewed
Mar 25, 2024
| return result.WithError(fmt.Errorf("can't create the package installer: %w", err)) | ||
| } | ||
| installedPackage, err := packageInstaller.Install() | ||
| installedPackage, err := packageInstaller.Install(ctx) |
There was a problem hiding this comment.
Maybe add here context.WithoutCancel(ctx) to allow running teardown ?
Currently, it does not deletes the package if it is pressed Ctrl+C during the installation.
2024/03/25 11:06:40 DEBUG Skip validation of the built .zip package
2024/03/25 11:06:40 DEBUG POST https://127.0.0.1:5601/api/fleet/epm/packages
^C2024/03/25 11:06:40 INFO Signal caught!
2024/03/25 11:06:40 ERROR request failed error="Post \"https://127.0.0.1:5601/api/fleet/epm/packages\": context canceled" method=POST url=https://127.0.0.1:5601/api/fleet/epm/packages
interrupted
There was a problem hiding this comment.
Fixed in ecd4600, along with the tear down context.
At the end I am only running the tear down if the installation failed by context cancellation, in other cases I think we can assume that the package was not installed.
💚 Build Succeeded
History
cc @jsoriano |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1679, to provide contexts to kibana client.