Handle detection of upgraded shell #1737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
approved these changes
Mar 21, 2024
💚 Build Succeeded
cc @jsoriano |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a shell process is upgraded in Linux, the link in the proc file system breaks. In this case the link can be resolved in some cases with the
(deleted)suffix message. This is what happens with the library we use to get information from processes.In these cases the output of
elastic-package stack shellinitlooks like that:$ elastic-package stack shellinit Detected shell: bash (deleted) Error: shellinit failed: cannot get shell init template: shell type is unknown, should be one of bash, dash, fish, sh, zsh, pwsh,Handle these cases by removing the
(deleted)suffix.