internal/fields: fix handling of boolean keyword fields #1752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
In some packages boolean fields are treated as keywords. Changing the mapping of those fields would be a breaking change so allow these fields to be considered u1 integers.
efd6
force-pushed
the
bools_are_numbers_too
branch
from
b52a28c to
e23aac5
Compare
|
test integrations |
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#9537 |
jsoriano
reviewed
Apr 8, 2024
| var isNumber bool | ||
| switch val := val.(type) { | ||
| case float64, []float64: | ||
| case bool, []bool, float64, []float64: |
There was a problem hiding this comment.
Could you please add an example of this in a test package?
Comment on lines
+702
to
710
| loop: | ||
| for _, v := range val { | ||
| _, ok := v.(float64) | ||
| if !ok { | ||
| switch v.(type) { | ||
| case bool, float64: | ||
| default: | ||
| isNumber = false | ||
| break | ||
| break loop | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit. I wonder if we can avoid the label.
for _, v := range val {
switch v.(type) {
case bool, float64:
default:
isNumber = false
}
if !isNumber {
break
}
}
There was a problem hiding this comment.
The generated code is worse for arguably less clear source. https://godbolt.org/z/fqrvEfrcW
There was a problem hiding this comment.
In general I consider the use of labels as less clear if there are alternatives. Here itself I had to think twice if this loop: was a special keyword for the switch that I didn't know about. But I guess this is a matter of opinions, so as you prefer 🙂
💚 Build Succeeded
History
cc @efd6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some packages boolean fields are treated as keywords. Changing the mapping of those fields would be a breaking change so allow these fields to be considered u1 integers.
Please take a look.