Skip to content

Reduce verbosity when checking if package embeds ECS #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Reduce verbosity when checking if package embeds ECS #1774

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fef93a
Reduce verbosity when checking if package embeds ECS
jsoriano Apr 16, 2024
c43423f
Fix formatting
jsoriano Apr 16, 2024
5e99b36
More descriptive
jsoriano Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions internal/fields/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,9 +303,6 @@ func initDependencyManagement(packageRoot string, specVersion semver.Version, im

// Check if the package embeds ECS mappings
packageEmbedsEcsMappings := buildManifest.ImportMappings() && !specVersion.LessThan(semver2_3_0)
if !packageEmbedsEcsMappings {
logger.Debugf("Package does not embed ECS mappings")
}

// Check if all stack versions support ECS mappings
stackSupportsEcsMapping, err := supportsECSMappings(packageRoot)
Expand All @@ -323,7 +320,7 @@ func initDependencyManagement(packageRoot string, specVersion semver.Version, im
if err != nil {
return nil, nil, err
}
logger.Debug("Imported ECS fields definition from external schema for validation")
logger.Debugf("Imported ECS fields definition from external schema for validation (embedded in package: %v, stack uses ecs@mappings template: %v)", packageEmbedsEcsMappings, stackSupportsEcsMapping)
schema = ecsSchema
}

Expand Down