Remove support for Docker Compose v1 #1785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
reviewed
Apr 18, 2024
jsoriano
commented
Apr 18, 2024
| logger.Errorf("Unable to determine Docker Compose version: %v. Defaulting to 1.x", err) | ||
| c.dockerComposeV1 = true | ||
| return &c, nil | ||
| return nil, fmt.Errorf("unable to determine Docker Compose version: %w", err) |
There was a problem hiding this comment.
Making this an error now, the main reason for this to fail is that docker compose command is not found.
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @jsoriano |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elastic-package is likely not working with Docker Compose v1 at this point, and it is discontinued since last year. Completely remove support for it.