-
Notifications
You must be signed in to change notification settings - Fork 127
Update volumes to use bind type #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/test |
| volumes: | ||
| - ${SERVICE_LOGS_DIR}:/tmp/service_logs/ | ||
| - ${LOCAL_CA_CERT}:/etc/ssl/certs/elastic-package.pem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know what is the default type when using this syntax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked in a local run, and the type is also "bind", but the Mode changes from "rw" to empty string. I haven't found what that means exactly...
"Mounts": [
{
"Type": "bind",
"Source": "/home/mariorodriguez/.elastic-package/profiles/default/certs/ca-cert.pem",
"Destination": "/etc/ssl/certs/elastic-package.pem",
"Mode": "rw",
"RW": true,
"Propagation": "rprivate"
},
{
"Type": "bind",
"Source": "/home/mariorodriguez/.elastic-package/tmp/service_logs/agent-sophos-utm",
"Destination": "/tmp/service_logs",
"Mode": "",
"RW": true,
"Propagation": "rprivate"
},
{
"Type": "bind",
"Source": "/home/mariorodriguez/.elastic-package/tmp/service_logs/agent-sophos-utm",
"Destination": "/run/service_logs",
"Mode": "",
"RW": true,
"Propagation": "rprivate"
}
],There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the service that was failing was because it was expecting the logs in /run/service_logs ?
At the end, all those mounts look similar in the configuration shown with a docker inspect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated settings to set explicitly read only or read write for those volumes, and keeping the same syntax in all mounts.
💚 Build Succeeded
History
cc @mrodm |
Use the same definitions for volumes as in the Elastic Agent defined in the stack:
elastic-package/internal/stack/_static/docker-compose-stack.yml.tmpl
Lines 142 to 150 in c2ff98b