Return stderr as part of the error when compose fails #1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
LGTM !
This would help us to find easier the errors raised by docker. For instance errors like:
validating /home/user/Coding/work/integrations/packages/oracle_weblogic/_dev/deploy/docker/docker-compose.yml: version must be a string
that were just shown in debug mode.
Thanks!!
💚 Build Succeeded
History
cc @jsoriano |
jsoriano
added a commit
that referenced
this pull request
Jun 6, 2024
In #1801 we introduced a virtual tty to capture docker compose output as it is generated in normal consoles. The library we use for that doesn't work on Windows, breaking stack management and tests depending on it. While we find an alternative, remove the use of PTY in Windows, effectively reverting #1801 on this platform. Add also a test to check that elastic-package stack keeps working on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect the output from stderr when an error running docker compose happens. This should give more information about the cause of the failure, even when debug mode is not used.