Add support for working copies created with git worktree #1803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
approved these changes
Apr 26, 2024
internal/files/repository.go
Outdated
| } | ||
| var worktree gitWorktree | ||
| dec := yaml.NewDecoder(bytes.NewBuffer(content)) | ||
| dec.KnownFields(true) |
There was a problem hiding this comment.
Nit. Do we need this? This can be an issue if some other field is added to this file, right?
There was a problem hiding this comment.
TBH I don't know if that file could have other fields, so probably it's better to just remove it and ensure that at least the file contains "gitdir"...
internal/files/repository.go
Outdated
| "gopkg.in/yaml.v3" | ||
| ) | ||
|
|
||
| func isGitWorktree(path string) error { |
There was a problem hiding this comment.
Nit. We could maybe add some test cases for this function.
jsoriano
reviewed
Apr 26, 2024
💚 Build Succeeded
History
cc @mrodm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for working copies created with
git worktreecommand.Working copies created with this command do not have a
.gitfolder, instead those working copies have a.gitfile where it is indicated where the reference repository is. For isntance:Currently,
elastic-packagefails since.gitis not a folder with this error:buildfolder does not exist andelastic-packageneeds to create it