Skip to content

Upgrade go version to 1.25.3 for root.ReadFile and root.WriteFile #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
Oct 23, 2025
Merged

Upgrade go version to 1.25.3 for root.ReadFile and root.WriteFile #3015

merged 54 commits into from
Oct 23, 2025

Conversation

@teresaromero
Copy link
Contributor

@teresaromero teresaromero commented Oct 22, 2025 •
edited
Loading

Related to the work done at #2957 the repository could benefit from upgrading the go version to 1.25.3 where the root api is updated and ReadFile + WriteFile are now available from the root type.

Updated the related code to use these new functions.

This PR is relative to #2957 so only last 2 commits are new code

@teresaromero
improve comments for Link struct and its fields in linkedfiles.go
75dae97
@teresaromero
refactor: enhance newLinkedFile function for better error handling an…
83e13ad 
…d clarity
@teresaromero
test: add unit test for newLinkedFile function to validate link file …
9139bb2 
…processing
@teresaromero
decoupled repoRoot from lint cmd and docs
60672b2
@teresaromero
update repository root handling across multiple components
211c7c9
@teresaromero
standardize repository root handling across build, lint, and links ma…
0b61910 
…p files
@teresaromero
ensure repository root is properly closed in multiple command actions…
ce07ec3 
… and tests
@teresaromero
add repoRoot parameter to build command action
0deae99
@teresaromero
update linked file handling to use absolute paths and improve clarity
1fc643a
@teresaromero
add copyright notice to packages_test.go file
6820b49
@teresaromero
refactor linkedfiles_test.go to use os.MkdirAll for directory creation
2c16cab
@teresaromero
implement repository root handling in benchmark and install commands,…
403527e 
… and update options in rally and stream runners
@teresaromero
read repoRoot at test runner cmd
96d5129
@teresaromero
refactor linkedfiles_test.go to use filepath.Join for constructing li…
90ba403 
…nk file paths
@teresaromero
inject repoRoot to needed test options
aeeee55
@teresaromero
Update data stream tests to include repoRoot parameter
385fc89
@teresaromero
Ensure repoRoot is closed in all data stream test cases
9edca9b
@teresaromero
Remove unnecessary directory change in createAndCheckDataStream function
c60b836
@teresaromero
Merge branch 'main' into 2797-detach-repo-root
679c566
@teresaromero
refactor at copyLicenceTextFile to ensure license inside reporoot, re…
ef3497f 
…factor tests and added readme note
@teresaromero
Merge branch 'main' into 2797-detach-repo-root
1f591bf
@teresaromero
refactor linkefiles management to use relative paths and root
ec2a7e1
@teresaromero
revert linksDefinitionsFilePath from public to private
169777f
@teresaromero
add validation for RepoRoot in Options
9229664
@teresaromero
clarify variable name for included file path in newLinkedFile function
0436a37
@teresaromero
simplify checksum comparison logic in newLinkedFile function
9793ffd
@teresaromero
refactor findRepositoryLicensePath to use repoRoot
5d6ef55
@teresaromero
refactor copyLicenseTextFile to use repoRoot.Stat
ecfeb9b
@teresaromero
refactor FindPackageRoot and handle error on FindPackageRootFrom calls
4412b0b
@teresaromero
remove repoRoot.Write and Read
9b7a721
@teresaromero
fix: correct grammar in comments for license file handling
5429121
@teresaromero
update copyLicenseTextFile function to improve clarity and error hand…
b3e73ac 
…ling
@teresaromero
enhance findRepositoryLicensePath function to check for empty license…
563522f 
… files
@teresaromero
improve path handling in TestFindRepositoryLicense and TestCopyLicen…
bfe509e 
…seTextFile
@teresaromero
rename test function and update comment for clarity
59436db
@teresaromero
remove unnecessary blank lines in test files for improved readability
248a704
@teresaromero
rename PackageRoot to PackageRootPath for consistency across builder …
c74c6c8 
…and installer
@teresaromero
add repository root handling in benchmark and test runner commands
68ed0d8
@teresaromero
rename newLinkMap to newEmptyLinkMap and revert related functions to …
54d8502 
…use value receiver instead of pointer
@teresaromero
update findRepositoryLicensePath to use os.ReadFile and improve error…
3b32fcc 
… handling in tests
@teresaromero
remove RepositoryRoot references from FleetAgentPolicy, rename RootPa…
8af2c99 
…th to PackageRootPath
@teresaromero
refactor copyLicenseTextFile to enforce absolute target license path …
d08ed58 
…and update related tests
@teresaromero
refactor build package handling to inject buildDir
c4a5205
@teresaromero
refactor readme generation to include sourceFilesRoot parameter and u…
5d84f01 
…pdate related tests
@teresaromero
Merge branch 'main' into 2797-detach-repo-root
c8b06ad
@teresaromero
streamline linked files inclusion in BuildPackage function prior to r…
102dfcd 
…esolve external fields
@teresaromero
Merge branch 'main' into 2797-detach-repo-root
24a9f73
@teresaromero
restore zipped built package path to build/packages
7570581
@teresaromero
Add repository root handling to test runner and installer
94a16d7
@teresaromero
Update Go version to 1.25.3 and refactor license file handling in tests
6d2e054
@teresaromero
Refactor license file handling in tests to use repositoryRoot consist…
d939edc 
…ently
@teresaromero teresaromero changed the title Update go version to 1.25.3 Upgrade go version to 1.25.3 for root.ReadFile and root.WriteFile Oct 22, 2025
@teresaromero teresaromero marked this pull request as ready for review October 22, 2025 12:51
@teresaromero teresaromero requested a review from a team as a code owner October 22, 2025 12:51
@jsoriano jsoriano mentioned this pull request Oct 23, 2025
Open
@jsoriano
Copy link
Member

jsoriano commented Oct 23, 2025

Could you please rebase this PR after merging #2957? Thanks!

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 23, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

@teresaromero teresaromero merged commit ea34e3a into elastic:main Oct 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@teresaromero @jsoriano @elasticmachine